dm-8216 Histogram for long values #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lznakano
reviewed
Nov 10, 2016
| for (int i = 1; i < nBin; i++) { | ||
| binMin[i] = bins[i - 1]; | ||
| } | ||
| System.arraycopy(bins, 0, binMin, 1, nBin-1); |
There was a problem hiding this comment.
Nice! Learned a good way to do array copy.
|
It looks good to me. It showed long values. Nice work, especially the modification to the java code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test, use firefly_test_data/DAXTestData/RunDeepForcedSource_limit100.csv
The following columns are long: id, coordHtmId20, objectId, exposureId.
(The display should be fine – compared to dev version – even though the precision can be reduced with respect to the original.)
The inherent limitation is that Javascript numbers are 64-bit float point, so the 63 bits in Long are converted to 52 bits of Double, hence the precision is inevitably lost if a number is long enough. Even if we find a way to handle arbitrary precision numbers in Javascript, they are not currently supported by Highcharts charting library.