DM-8176: tweeks for lsst entry points and options #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added lsst-api-triview.html for api launch with afw.display - added lsst-pdac-triview.html for pdac entry point - PROCESS_SCROLL action now has a way to turn off bounds checking
loitly
approved these changes
Nov 8, 2016
| MenuItemKeys: {maskOverlay:true}, | ||
| imageTabs: [ 'fileUpload', 'url', '2mass', 'wise', 'sdss', 'msx', 'dss', 'iras' ], | ||
| irsaCatalogFilter: 'lsstFilter', | ||
| catalogSpacialOp: 'polygonWhenPlotExist' |
There was a problem hiding this comment.
If it's not already so, these properties under global firelfy should be documented.
There was a problem hiding this comment.
Yes, I agree. I am thinking about maybe putting them into an object in the store. Then the rest of the app references them from the store instead of window.firefly.
- Added documentation for the app options - Moved the app options for window.firefly.app.options instead of window.firefly - Inserted the app options into the store, options are now retrieved from AppDataCntlr.getAppOptions() instread of window.firefly - Since the options are loaded later in the application initialization process I had to make some changes in several files that were dependent on the options being loaded very early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The html files might eventually be moved to an lsst repository