DM-8162: Call IRSAViewer to display images directly via URL #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robyww
approved these changes
Nov 7, 2016
| @@ -65,11 +65,12 @@ function makeSinglePlotPayload(vr, rawPayload ) { | |||
|
|
|||
|
|
|||
| if (isArray(wpRequest)) { | |||
| if (!plotId) plotId= req.getPlotId(); | |||
| if (!plotId) plotId= req.getPlotId() || uniqueId('defaultPlotId-'); | |||
There was a problem hiding this comment.
nice way to approach this problem.
|
Works as intended. Is passing the wpRequest object covers all the needs as before? If yes, i'm fine with the PR. Otherwise we need to work on it, specially to match teh need from NED for example. I am not aware of NED's other use cases. This is the only one in the ticket. |
|
I've asked more example from NED team, for now i think is more than fine so you can merge the PR into RC. If there is something more or special, i will raise a ticket. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-8162
As described by the title, allow plotImage to be called via url.
In the above link, you'll find more information on how to construct the url with one sample test url.
This PR is to merge into 'rc' branch. Once it's in rc, we will merge rc back into dev.