-
Notifications
You must be signed in to change notification settings - Fork 16
DM-8010: Add LSSTMetaSearch and LSSTCatalogSearch processors #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The size for box search or the radius for cone or elliptical searches sent to the server for LSST catalog search is made in the unit of 'degree'. |
…o arcsec for elliptical method search, and all columns are selected if the selcol=null
I have built the branch in my own computer and tested the four search methods: cone, ellipse, box, polygon using Lijun's test cases. Only the box one doesn't return any result (the application keeps running...) From the log file I can tell the table search part is done successfully though. |
I tested the box search. The reason is that the query results is empty upperLeftPt = {WorldPt@4604} "9.490002778428433; I just wrote code to handle such case. FYI Lijun On 11/2/16 5:20 PM, ymeiymei wrote:
Lijun Zhang LSST/IPAC |
Double check your calculation. Are you sure you used each side length as On 11/2/16, 6:14 PM, Lijun Zhang wrote:
|
…e unit bag in box search
To test it,
Check it out and build.
Start firefly view, then enter the following info based on the method:
Cone search:
UserTargetPt: 9.49,-1.24
Radius: 0.01 degree
Box Search:
UserTargetPt: 9.49,-1.24
Radius: 0.01 degree
Elliptical Search:
9.49, -1.24
Radius: 0.01 degree
Polygon Search:
9.5 -1.2, 9.6 -1.24, 9.4 -1.24
Known issue:
When the degree unit is selected, it still passed as arcsec
When all columns are selected by default, it passed null
Suggest:
UI passes the unit, the server side handles the conversion based on the search methods.
Thanks for reviewing it.
[11/1/16 at 5:37PM]
After discussing with Cindy and after her changes, the following changes are made:
If the UI sends a null for selcol, all columns are selected.
For radius UI, he "degree" unit is used The server side converts the unit based on the
search methods.
Datatypes inconsistence (for the same column):
meta search (LSSTMetaSearch): select SHOW COLUMNS
return double, boolean
catalog search (LSSTCatalogSearch): select * (select id, parent, ...)
return float for double
return null for boolean
When the DataType is created, if the type is no null, the type in catalog search is always
used. If it is null, the type in meta search is used.
Add throw Exception for LSSTCatalogSearch. LSSTMetaSearch had the exception handled.