Skip to content

DM-8010: Add LSSTMetaSearch and LSSTCatalogSearch processors #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 7, 2016

Conversation

lznakano
Copy link
Contributor

@lznakano lznakano commented Nov 1, 2016

To test it,

Check it out and build.
Start firefly view, then enter the following info based on the method:
Cone search:
UserTargetPt: 9.49,-1.24
Radius: 0.01 degree
Box Search:
UserTargetPt: 9.49,-1.24
Radius: 0.01 degree
Elliptical Search:
9.49, -1.24
Radius: 0.01 degree
Polygon Search:
9.5 -1.2, 9.6 -1.24, 9.4 -1.24

Known issue:
When the degree unit is selected, it still passed as arcsec
When all columns are selected by default, it passed null

Suggest:
UI passes the unit, the server side handles the conversion based on the search methods.

Thanks for reviewing it.

[11/1/16 at 5:37PM]
After discussing with Cindy and after her changes, the following changes are made:

  1. If the UI sends a null for selcol, all columns are selected.

  2. For radius UI, he "degree" unit is used The server side converts the unit based on the
    search methods.

  3. Datatypes inconsistence (for the same column):
    meta search (LSSTMetaSearch): select SHOW COLUMNS
    return double, boolean
    catalog search (LSSTCatalogSearch): select * (select id, parent, ...)
    return float for double
    return null for boolean

    When the DataType is created, if the type is no null, the type in catalog search is always
    used. If it is null, the type in meta search is used.

  4. Add throw Exception for LSSTCatalogSearch. LSSTMetaSearch had the exception handled.

@cwang2016
Copy link
Contributor

The size for box search or the radius for cone or elliptical searches sent to the server for LSST catalog search is made in the unit of 'degree'.

@ymeiymei
Copy link
Contributor

ymeiymei commented Nov 3, 2016

I have built the branch in my own computer and tested the four search methods: cone, ellipse, box, polygon using Lijun's test cases. Only the box one doesn't return any result (the application keeps running...) From the log file I can tell the table search part is done successfully though.

@lznakano
Copy link
Contributor Author

lznakano commented Nov 3, 2016

I tested the box search. The reason is that the query results is empty
with the calculated the minRa/Dec maxRa/Dec calcualted.

upperLeftPt = {WorldPt@4604} "9.490002778428433;
-1.239997222222222;EQ_J2000"
upperRight = {WorldPt@4609} "9.48999722157157;-1.239997222222222;EQ_J2000"
lowerLeft = {WorldPt@4615} "9.490002778428433;-1.2400027777777778;EQ_J2000"
lowerRightPt = {WorldPt@4622}
"9.48999722157157;-1.2400027777777778;EQ_J2000"

I just wrote code to handle such case.

FYI

Lijun

On 11/2/16 5:20 PM, ymeiymei wrote:

I have built the branch in my own computer and tested the four search
methods: cone, ellipse, box, polygon using Lijun's test cases. Only
the box one doesn't return any result (the application keeps
running...) From the log file I can tell the table search part is done
successfully though.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#218 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALbTfRpbNcY6tz_zES9XYflhxodKQ3VDks5q6SjhgaJpZM4KmZ4g.

Lijun Zhang

LSST/IPAC
California Institute of Technology
770 S. Wilson Ave, Mail Code 100-22
Pasadena, CA 91125, USA
Voice: 1-626-395-1972 Fax:1-626-395-1816

@ymeiymei
Copy link
Contributor

ymeiymei commented Nov 3, 2016

Double check your calculation. Are you sure you used each side length as
0.01 degrees? It doesn't look like.

On 11/2/16, 6:14 PM, Lijun Zhang wrote:

I tested the box search. The reason is that the query results is empty
with the calculated the minRa/Dec maxRa/Dec calcualted.

upperLeftPt = {WorldPt@4604} "9.490002778428433;
-1.239997222222222;EQ_J2000"
upperRight = {WorldPt@4609} "9.48999722157157;-1.239997222222222;EQ_J2000"
lowerLeft = {WorldPt@4615}
"9.490002778428433;-1.2400027777777778;EQ_J2000"
lowerRightPt = {WorldPt@4622}
"9.48999722157157;-1.2400027777777778;EQ_J2000"

I just wrote code to handle such case.

FYI

Lijun

On 11/2/16 5:20 PM, ymeiymei wrote:

I have built the branch in my own computer and tested the four search
methods: cone, ellipse, box, polygon using Lijun's test cases. Only
the box one doesn't return any result (the application keeps
running...) From the log file I can tell the table search part is done
successfully though.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub

#218 (comment),

or mute the thread

https://github.com/notifications/unsubscribe-auth/ALbTfRpbNcY6tz_zES9XYflhxodKQ3VDks5q6SjhgaJpZM4KmZ4g.

Lijun Zhang

LSST/IPAC
California Institute of Technology
770 S. Wilson Ave, Mail Code 100-22
Pasadena, CA 91125, USA
Voice: 1-626-395-1972 Fax:1-626-395-1816


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#218 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AChUuWLP_PGt44aIh7JChUGxsqZ6Rtkkks5q6TWDgaJpZM4KmZ4g.

@lznakano lznakano merged commit 87d1336 into dev Nov 7, 2016
@robyww robyww deleted the DM-8010-Access_DAC branch November 30, 2016 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants