Skip to content

refactoring to support better controller registration and sage registration #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2016
Merged

refactoring to support better controller registration and sage registration #217

merged 2 commits into from
Nov 1, 2016

Conversation

robyww
Copy link
Contributor

@robyww robyww commented Oct 31, 2016

No description provided.

loitly
loitly approved these changes Nov 1, 2016
View reviewed changes
Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should consider not exporting actionCreators and reducers where it's not referenced outside of the controller. Besides that, everything looks fine.

@robyww robyww merged commit a2610c6 into dev Nov 1, 2016
@robyww robyww deleted the dm-8149-registration branch November 1, 2016 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loitly loitly loitly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robyww @loitly