Dm 8028 unit test utility #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loitly
approved these changes
Oct 20, 2016
| } | ||
| } | ||
|
|
||
| public static File loadFile(Class cls, String tblFile) { |
There was a problem hiding this comment.
This function is poorly named. Should be resolveFile(Class cls, String fname) or something like it.
You are not loading anything and it has nothing to do with table.
There was a problem hiding this comment.
It reads a table fie in the test tree and returns a DataGroup object. I have named:
loadFIts: return a FITS
loadFitsRead: return a FitsRead
loadFitsReadArray: return a FitsRead array
loadFile : return a File
Does it make more sense if it is named as loadDataGroup?
lznakano
force-pushed
the
DM-8028-UnitTestUtility
branch
from
8b7b5a8 to
5f47879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A utility class, FileLoader, is added. It is in the packageedu.caltech.ipac.firefly.util under the test tree. Following 8 files are modified accordingly:
HistogramTest.java
ProjectionTest.java
HistogramProcessorTest
StatisticProcessorTest
PhaseFoldedLightCurveTest
IpactableTest
ZscaleTest
GridTest
To test it, please check out of this branch and also the data branch in firefly_test_data. The data branch has exactly the same name.
DM-7783 is depending on this branch. Once it is merged, the DM-7783 can be finalized.