Skip to content

DM-7918 Constraint column render error and the state update error when column constraint changes #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2016

Conversation

cwang2016
Copy link
Contributor

Fixed the bugs for catalog search constraints, the bugs are:

  • the constraint rendering became empty when 'enter' key is pressed or the focus on the cell is moved away.
  • the state regarding the search constraints is not updated when the constraint changes.

Note:
If any entered column constraint is checked to be invalid, the error message will be shown in a popup box when the 'search' button is clicked and the search will stop.

@cwang2016
Copy link
Contributor Author

cwang2016 commented Oct 10, 2016

A feature fixing:
The cell of column constraints is highlighted in case some invalid constraint string is entered.

@ejoliet
Copy link
Contributor

ejoliet commented Oct 11, 2016

I've tested the fix, seems ok. Thanks!

@cwang2016 cwang2016 merged commit ad5f8b9 into dev Oct 11, 2016
@cwang2016 cwang2016 deleted the DM-7918-CatalogConstraints branch October 11, 2016 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants