DM-7765 Render the text defined as the 'text' property value of a region on PNG #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test sample: |
robyww
approved these changes
Sep 29, 2016
| * @param name string - ex: Arieal, Courier, Ties, Helvetica, sans-serif, BRAGGADOCIO | ||
| * @param point string (font size) ex: 10, 12, 14, 16 | ||
| * @param weight string ex: normal, bold | ||
| * @param slant string ex: normal, italic |
There was a problem hiding this comment.
I know the jsdocs were wrong before bug it you add to them you should go ahead and fix them.
Such as:
@param {string} slant ex: normal, italic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rendering of the region associated text was missing in the PNG.
This issue is fixed by creating a separate text region with the location calculated at JS parts, the text value and font defined in the original region, and sending the created text regions as well as the original regions to the server for producing the PNG.