Skip to content

DM-7700: Atlas table filtering doesn't work properly #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2016

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Sep 27, 2016

https://jira.lsstcorp.org/browse/DM-7700

This is only a problem in Atlas which makes it a little harder to test.
Build locally then deploy it on irsawebdev1 or proxy irsawebdev1 to your localhost if you want to test it.

@ejoliet
Copy link
Contributor

ejoliet commented Sep 28, 2016

Checked in atlas that the table is filtered correctly.
Review done.

Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a side effect of the changes is that the help anchor in the xy-plot toolbar is out of its position and icon are no longer highlighted.

@loitly
Copy link
Contributor Author

loitly commented Sep 28, 2016

The help anchor was an introduced side effect. The xy-plot highlighting icon has always been that way. But, I'll fix them both.

 - fix xy-plot help icon alignment
 - highlight xy-plot button when hover
@loitly
Copy link
Contributor Author

loitly commented Sep 28, 2016

Changes has been committed. Please verify and approve.

@loitly loitly merged commit 444727d into dev Sep 28, 2016
@loitly loitly deleted the DM-7700_atlas_filter branch September 28, 2016 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants