Skip to content

DM-7164-LCviewer-ibe-preprocessor #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2016
Merged

Conversation

wmiipac
Copy link
Contributor

@wmiipac wmiipac commented Sep 23, 2016

  • Add ibe server request retrieve the images.
  • Fixed the makeProcessorRequest bug and few eslint errors in WebPLotRequest.

Fixed  the makeProcessorRequest bug and few eslint errors in WebPLotRequest.
Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove import blocks when the file is not existing anymore or not used because it gives a problem to load the lc.html.
I would also suggest to add js docs to those 2 files changed.


import {LO_VIEW, LO_MODE, SHOW_DROPDOWN, SET_LAYOUT_MODE, getLayouInfo, dispatchUpdateLayoutInfo, dropDownHandler} from '../../core/LayoutCntlr.js';
import {TBL_RESULTS_ADDED, TABLE_LOADED, TBL_RESULTS_ACTIVE, TABLE_HIGHLIGHT} from '../../tables/TablesCntlr.js';
import {getCellValue, getTblById, makeTblRequest} from '../../tables/TableUtil.js';
import {updateSet} from '../../util/WebUtil.js';
import {dispatchPlotImage} from '../../visualize/ImagePlotCntlr.js';
import WebPlotRequest from '../../visualize/WebPlotRequest.js';
import {WebPlotRequest,TitleOptions} from '../../visualize/WebPlotRequest.js';
import {makeWiseLcPlotRequest} from '../../metaConvert/WiseLcViewRequestList';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not used, gives a problem of not found and breaks the lc.html page. Please remove unused import otherwise the app doesn't load.

@wmiipac
Copy link
Contributor Author

wmiipac commented Sep 27, 2016

Ok, sorry the "makeWiseLcPlotRequest" was in my local as I was trying
different ways, should have taking it out when I did the pull request.

On 9/26/16 1:18 PM, Emmanuel Joliet wrote:

@ejoliet requested changes on this pull request.

Remove import blocks when the file is not existing anymore or not used
because it gives a problem to load the lc.html.
I would also suggest to add js docs to those 2 files changed.


In src/firefly/js/templates/lightcurve/LcManager.js
#192 (review):

import {LO_VIEW, LO_MODE, SHOW_DROPDOWN, SET_LAYOUT_MODE, getLayouInfo, dispatchUpdateLayoutInfo, dropDownHandler} from '../../core/LayoutCntlr.js';
import {TBL_RESULTS_ADDED, TABLE_LOADED, TBL_RESULTS_ACTIVE, TABLE_HIGHLIGHT} from '../../tables/TablesCntlr.js';
import {getCellValue, getTblById, makeTblRequest} from '../../tables/TableUtil.js';
import {updateSet} from '../../util/WebUtil.js';
import {dispatchPlotImage} from '../../visualize/ImagePlotCntlr.js';
-import WebPlotRequest from '../../visualize/WebPlotRequest.js';
+import {WebPlotRequest,TitleOptions} from '../../visualize/WebPlotRequest.js';
+import {makeWiseLcPlotRequest} from '../../metaConvert/WiseLcViewRequestList';

not used, gives a problem of not found and breaks the lc.html page.
Please remove unused import otherwise the app doesn't load.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#192 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALaeg41XrkJ-9sSntxY57t8gBXTEhq6Zks5quCiygaJpZM4KFSM3.

@ejoliet ejoliet merged commit a702694 into dev Sep 28, 2016
@ejoliet ejoliet deleted the DM-7164-LCviewer-ibe-preprocessor branch September 28, 2016 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants