Skip to content

DM-7336:fixed the algorithm bug in Geom.java #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2016
Merged

Conversation

lznakano
Copy link
Contributor

@lznakano lznakano commented Sep 22, 2016

Emmanuel,

Can you please take a look and let me know if you still see problems?

Thanks!

@lznakano
Copy link
Contributor Author

Emmanuel:

Please test it and let me know if it still has problems. THANKS!

@ejoliet
Copy link
Contributor

ejoliet commented Sep 22, 2016

Looks good to me. I've checked randomly on other image operations and it looks ok.

Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am concerned about this approach to solve this problem.
I am not comfortable with changes to Geom unless it is thoroughly understood. Test cases should be written before we modify it. Right now no one understands Geom and we are very dependent on it.

Beyond that I think the right approach to this problem is to add a trimNaN option to FitsRead.createFitsReadPositionAngle so on createFitsReadRotated calls the option can be passed. This keeps the trimming work out of Geom. The problem with that idea is that it might use more memory to do the operation.

I would like @lznakano , @ymeiymei, (maybe @xiuqin) and I to sit and talk about it.

@lznakano lznakano merged commit e84f993 into dev Sep 30, 2016
@robyww robyww deleted the DM-7336-rotation branch October 13, 2016 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants