Skip to content

Dm 4127 mask over lay #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 27, 2016
Merged

Dm 4127 mask over lay #189

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
862c31c
DM-7508: testing more rules
Sep 9, 2016
8113a26
DM-4127: added codes in FlipXY to handle mask flips
Sep 12, 2016
d5d7ab7
DM-4127:fixed the flipped bugs which caused the mask layer flipped wr…
Sep 20, 2016
3389870
DM-7695: fixed the bug in StretchDropDownView.jsx
Sep 22, 2016
bfc7dae
DM-4127: cleaned up the codes which were introduced by debugging
Sep 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/firefly/js/visualize/ui/StretchDropDownView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,12 @@ function stretchByType(pv,currRV,sType,min,max) {
}



/*
* LZ 9/21/16 DM-7695
*/
export function StretchDropDownView({plotView:pv}) {
var enabled= pv ? true : false;
var rv= primePlot(pv).plotState.getRangeValues();
var rv= primePlot(pv).plotState.getPrimaryRangeValues();//getRangeValues();//LZ 9/21/16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should not be any different than what was there before. In the JavaScript PlotState, getPrimaryRangeValues() is the same as getRangeValues() when passed with no parameters. Making this change should make no difference.

Also, I plan to deprecate getPrimaryRangeValues() on the JS side.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the line back as what it was: "var rv= primePlot(pv).plotState.getRangeValues()". But the color stretch box can no longer be opened because PlotState.js has not getRangeValues method. When "getPrimaryRangeValues()" is used, the color stretch box can be opened.

return (
<SingleColumnMenu>
<ToolbarButton text='Color stretch...'
Expand Down