Skip to content

DM-7116: change the title of drawing layer dialog based on the title of the active image #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2016

Conversation

cwang2016
Copy link
Contributor

Make the tile on the drawing layer dialog to be the same as the image title from either image or catalog search.

@ejoliet
Copy link
Contributor

ejoliet commented Sep 19, 2016

Sorry but i don't see the title changing. Do i have to build firefly and deploy fresh war?

@cwang2016
Copy link
Contributor Author

Yes, you have to do 'gradle :firefly:deploy :firefly:war".

@cwang2016
Copy link
Contributor Author

if you switch from DM-6980.

@ejoliet
Copy link
Contributor

ejoliet commented Sep 20, 2016

I did a purge, then a fresh build and deploy on tomcat where i have clean the webapps,etc.
Still don't see the title changing. Is it only me? Can @tgoldina or @robyww confirm?

@ejoliet
Copy link
Contributor

ejoliet commented Sep 20, 2016

Oh, i know. Yes, i can defintively see the title update. What i was confused is that i was looking at the title while i change the image active, and the title doesn't change unless i close and reopen the layer window.
I guess this is a different issue that can be brought later.

For now, it works as described in the ticket.
Review done.

@cwang2016 cwang2016 merged commit 852f6f4 into dev Sep 20, 2016
@cwang2016 cwang2016 deleted the DM-7116-DrawLayerDialog branch September 20, 2016 23:39
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this pull request has been merge it should be changed right away.

//}catch (E){
// //
//}
var title = get( getActivePlotView(visRoot()), ['plots', '0', 'title']);
Copy link
Contributor

@robyww robyww Sep 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct way to get the primary plot. The plots array should never be access directly. Beyond that 0 is not always the primary plot.
the primePlot function should always be called here.

The code should be

const plot= primePlot(visRoot());
title= plot ? plot.title : null;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants