Skip to content

DM-7487: add polygon values from active image in catalog search #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2016

Conversation

ejoliet
Copy link
Contributor

@ejoliet ejoliet commented Sep 16, 2016

Pre-calculated polygon area when this spatial search method is selected in the catalog search.
It will take part of the image and calculate the x,y pairs from active plot.
Please review it.

@ejoliet ejoliet force-pushed the DM-7487-catalog-search-default-polygon branch from 89caa73 to e91e88b Compare September 17, 2016 00:28
Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added feature works great. I recommend cleaning up the helper functions.

/**
* Helper to get polygon from image
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the helper functions defined below are used. Also, they contain unused imports as well as undefine function reference. If you want to keep these, it should be cleaned up and moved to a util type of file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unused function. Cleanup done.

@ejoliet ejoliet merged commit ab0fe4e into dev Sep 19, 2016
@ejoliet ejoliet deleted the DM-7487-catalog-search-default-polygon branch September 19, 2016 18:01
Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants