-
Notifications
You must be signed in to change notification settings - Fork 16
DM-6980: Fix PNG creation for marker #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the same thing the Xiuqin saw.
After talking to Cindy, I think there is still and issue with the markers (maybe with color change?) and another issue with catalogs. So the scope of this ticket is bigger than we thought.
We might not support all the shapes on server side. She is going to look into it.
More updates are added to fix the issues regarding PNG download from both image search and catalog search, including
|
See attached image on left the PNG downloaded and right the browser viewer. Can't reproduce. |
Update: the fix works in firefly viewer. Maybe it doesn't in the API mode? |
Works also great in IRSAVIewer, i've checked. Really minor: compass rose is included in PNG but not the labels 'N', 'E'. |
more update: |
Fixing method:
Marker size is represented by a small pure number (magnitude of thousandth) in term of world coordinate (J2000). World coordinate is a hint to set the size value with 'degree' unit, otherwise the size value was treated with 'pixel' unit, too small to be shown in the PNG.