Skip to content

DM-6980: Fix PNG creation for marker #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2016
Merged

DM-6980: Fix PNG creation for marker #183

merged 3 commits into from
Sep 20, 2016

Conversation

cwang2016
Copy link
Contributor

Fixing method:
Marker size is represented by a small pure number (magnitude of thousandth) in term of world coordinate (J2000). World coordinate is a hint to set the size value with 'degree' unit, otherwise the size value was treated with 'pixel' unit, too small to be shown in the PNG.

@cwang2016
Copy link
Contributor Author

test:
select any image, click 'marker/footprint' button, select 'Add Marker', click 'save fits, png...' button, and choose 'png' for download, check if the marker is shown in the download PNG.

@xiuqin
Copy link
Contributor

xiuqin commented Sep 16, 2016

  1. The color of the marker does not show up in PNG.
  2. The Marker label does not show in PNG
  3. The catalog overlaid on image was square on screen, but cross (X) on PNG.

Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the same thing the Xiuqin saw.

After talking to Cindy, I think there is still and issue with the markers (maybe with color change?) and another issue with catalogs. So the scope of this ticket is bigger than we thought.

We might not support all the shapes on server side. She is going to look into it.

@cwang2016
Copy link
Contributor Author

More updates are added to fix the issues regarding PNG download from both image search and catalog search, including

  • showing the marker added from marker/footprint dropdown list.
  • showing the right color as color changed from drawing layer popup.
  • showing the marker with the right color and right point shape from catalog search.
  • showing the marker/footprint label.

@ejoliet
Copy link
Contributor

ejoliet commented Sep 19, 2016

I have tested this fix in http://localhost:8080/firefly/demo/ffapi-highlevel-test.html but i don't see the fix. Am i doing something wrong for testing?

See attached image on left the PNG downloaded and right the browser viewer.
screen shot 2016-09-19 at 3 18 41 pm

Can't reproduce.

@ejoliet
Copy link
Contributor

ejoliet commented Sep 19, 2016

Update: the fix works in firefly viewer. Maybe it doesn't in the API mode?

@ejoliet
Copy link
Contributor

ejoliet commented Sep 19, 2016

Works also great in IRSAVIewer, i've checked.

Really minor: compass rose is included in PNG but not the labels 'N', 'E'.

@cwang2016
Copy link
Contributor Author

more update:
change the color of compass labels, from 'black' to 'red'.

@cwang2016 cwang2016 merged commit b843c79 into dev Sep 20, 2016
@cwang2016 cwang2016 deleted the DM-6980-MarkerPNG branch September 20, 2016 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants