Skip to content

DM-7594: Display phase column with 8 decimal places precision #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2016

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Sep 14, 2016

https://jira.lsstcorp.org/browse/DM-7594
Also, add description meta to that column.

Also, add description meta to that column.
@ejoliet
Copy link
Contributor

ejoliet commented Sep 15, 2016

the displayed phase is now 8 decimal precision and the description appears too.

As the column is the last one in the table on the right-hand, the vertical scroll bar hide part of it. Is it possible to make the column wider so it shows the value (8 decimals) fully?

Minor (was in the ticket [DM-7595]: I've downloaded the table but i couldn't find any mention on the column 'phase'. Is it possible to add a comment with the column name 'phase' and the description as other columns?

I tried downloading the table. There is a comment with description of 'phase':

\ phase
\ ___ number of period elapsed since starting time.

Also, do you want to hide some of the columns by default?

@ejoliet
Copy link
Contributor

ejoliet commented Sep 15, 2016

About hiding columns, yes, probably we don't need all the columns, we can keep the fluxes, and time columns as first approach but i wouldn't change that until we get more details on those aspects.
For now is fine. Thank you!
Review done.

@loitly loitly merged commit 3463141 into dev Sep 16, 2016
@loitly loitly deleted the DM-7594_phase_column_precision branch September 16, 2016 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants