DM-7593: use phase folded code in processor and update test #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } catch (IpacTableException e) { | ||
| e.printStackTrace(); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
use Logger instead of stdOut.
|
I understand it was needed at first. But, now that lc app(lc.html) is available, this 'demo' code should be place there instead. Code looks fine. Review is complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this PR which make use of the phase folded code, updating phase folded processor and tests.
To see in action, go to
http://localhost:8080/firefly/firefly-dev.html
And click 'compute periodogram' tab.
Change period and phase fold.
The phase folded request built can be seen here: js/ui/TestQueriesPanel.jsx:142
The phase column displays '0.0' which is not enough (see ticket [DM-7593])