DM-7326: Adapt FireflyClient to Python 3. #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -157,7 +161,7 @@ def __init__(self, host=_my_localhost, channel=None): | |||
| self.connect() | |||
|
|
|||
| def _handle_event(self, ev): | |||
| for callback, eventIDList in self.listeners.items(): | |||
| for callback, eventIDList in list(self.listeners.items()): | |||
There was a problem hiding this comment.
Here is a case where futurize -2 is too conservative by wrapping self.listeners.items() in a list. The list() can be removed.
|
Review complete. Thank you for the cleanup and renaming. There are just a few instances where |
…y 'future -2'. Each list() case is checked.
|
It is great to resolve the puzzle on if applying list() to dict's keys(), items() and values(). Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sqr-014.lsst.io/v/DM-6315/index.html