DM-7511: add JSDoc generation into build system. #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "linenums" :true, | ||
| "collapseSymbols" : false, | ||
| "systemName" : "Firefly", | ||
| "theme" : "spacelab" |
|
Looks good. Review Complete |
|
Looked great. I did not dare to choose a theme because I am not sure which one works better. But the one you used is very good. I made some changes to move all the member methods under global to the corresponding namespace. I pushed my changes in the dev. If you have conflict when you merge, I can do the merge because I know which file I modified. Review complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-7511
To build war plus JS docs and deploy it, use
gradle :firefly:buildAllAndDeployorgradle :fi:bAATo see deployed JS docs, http://localhost:8080/firefly/jsdoc/