-
Notifications
You must be signed in to change notification settings - Fork 16
DM-5276: Upgrade JS third party packages #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- goal: babel 6, React 15, and latest version of webpack - upgrade most packages to latest versions as well - remove some unused packages - fixed warnings related to React upgrade
I've built the branch locally and did some random tests. It seems ok in general but so far i can see one problem: |
the 'x' now shows up, pushed the fix. |
The color picker api changed with upgrade. Fixed our code to work with it. |
Thanks for fixing those. I have found another problem: The compass rose doesn't show up, error log in the console says: Uncaught TypeError: (0 , _DirectionArrowDrawObj.makeDirectionArrowDrawObj) is not a function |
And stretch/color changes seems to be applied but shows a fail message on the image viewer, and the console throw the following log: |
…e old version of babel
fixed the direction arrow failure |
OK, it looks good as far as I know. I sure we will find a couple of more issues. @tgoldina needs to check the highcharts update. |
It looks like Loi got the latest version of react-highcharts, and it appears to work as expected, no errors - I've checked both regular and binned plots. |
Ok, I think it is good to merge. We fix other issues as we find them. Review Complete. |
Main purpose is to upgrade babel to v6, React to v15, and latest version of webpack.
Things you should be aware of in React 15: https://facebook.github.io/react/blog/2016/04/07/react-v15.html
As far as I can tell, they are all fixed in this pull request.
Don't forget to
gradle purge
first.The pull request should be built with a newly created node_module.
Also:
Original ticket:
https://jira.lsstcorp.org/browse/DM-5276