DM-7162: adding first skeleton and test for lightcurve handler #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added two processors (maybe it can be combined). They are both under firefly/server/query.
One is taking care of returning periodogram and peaks tables. The other is in charge of phase folding an input IPAC table (raw LC table).
I've added a handler to deal with the Nexsci API in the future. Ans an IRSA handler to deal with the extraction/parsing of both tables from the API result VOTable xml.
There is also a test to demonstrate how to get the tables out of a request.
For now, i'm faking the return API with a sample VOTable.
The request object (PeriodogramAPIRequest) expects input parameters needed for computing the periodogram (calling the API) and phase folding a raw light curve. (Note: Maybe we need to add the URL as part of the request so we can always change the API url directly from the client instead of doing it from the server?)
The phase folding is under development and need to be integrated in the handler. For now i'm returning the same raw table that i've passed in as input in the request.
I've added the test buttons in firefly-dev.html, they appear in the tab 'Compute periodogram' in the TestQueriesPanel (.jsx) component.
More offline discussion might be needed though.
Please, let me know if that make sense regarding the feature requirements and if it covers the future need.