Skip to content

Dm 6438 unit test using firefly test data #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 26, 2016

Conversation

lznakano
Copy link
Contributor

@lznakano lznakano commented Aug 31, 2016

Please take a look at this branch. The unit tests added in both java and javascript use the same testing data located in firefly_test_data/package_name.

To run javascript unit test at hydra/cm/firefly/src/firefly:
npm run test-unit -s
To run java unit test /hydra/cm/firefly:
/hydra/tps/gradle/bin/gradle :firefly:test

Thanks!

Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the test and it all looks fine. All test seem to pass. It is hard for me to get a feel for coverage but we can do that over time.

With Java JUnit we have a report of the results. We don't appear to have that for js testing. There probably needs to be a ticket created for future work understand our js testing a little better. That is out of scope of this ticket.

Using the parallel repository firefly_test_data seems to work well.

This was a very tedious ticket. Good job on tracking down all the issues.

@lznakano lznakano merged commit 314e953 into dev Sep 26, 2016
@lznakano lznakano deleted the DM-6438-unitTest_Using_firefly_test_data branch September 26, 2016 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants