Skip to content

DM-7448: Table reset unset option 'Show unit' initially set #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2016

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Aug 31, 2016

https://jira.lsstcorp.org/browse/DM-7448

Reset button does not work when options are set explicitly.

This the demo page below, the first table has showUnits and showFilters set to true. It used to work reset properly.
http://localhost:8080/firefly/demo/ffapi-highlevel-test.html

@ejoliet
Copy link
Contributor

ejoliet commented Aug 31, 2016

The option 'show unit' and 'filters' are kept after reset if they were selected initially. But if the page size is '15', after reset it returned to '100'. The reset should return '15' if this was the inital value.
Example: http://localhost:8080/firefly/demo/ffapi-highlevel-test.html,
'open table' will open external viewer with table page size set to 15. 'Reset' button reset the value to 100 instead of keeping the initial value in that case '15'.
I think is still a bug if we think about how reset should restore initial values. What do you think?

@ejoliet
Copy link
Contributor

ejoliet commented Sep 1, 2016

Has been fixed now. Thanks! Review completed.

@loitly loitly merged commit 9e4f9aa into dev Sep 1, 2016
@loitly loitly deleted the DM-7448_demo_reset_table branch September 1, 2016 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants