DM-7406: Create Light curve skeleton app #157
Conversation
- introduce template into firefly entry point. - create light curve as a template. - create viewer, controller, and results component for light curve. - these components are place holders and are not fully implemented. - create upload form for use during development.
|
Looks great!!! Nice starter page! I've uploaded a file and checked that everything was ok. |
| <script> | ||
| window.firefly = { | ||
| app: { | ||
| template: 'LightCurveViewer', |
There was a problem hiding this comment.
The triview is the default template? I think we should probably specify it.
There was a problem hiding this comment.
Yes, FireflyViewer is the default. It's documented via jsdoc in FFEntryPoint.app.
|
Is LayoutCntlr more general than just the tri-view? I know it is required for expanded but it is not clear if is for others. Maybe I don't understand it well enough. I am having trouble which what goes in LayoutCntlr. Yes. LayoutCntlr contains the common layout states like, dropdown, expanded, standard. It may also carry additional states specific to the component, like images. This is how saga or action listener can dynamically change the layout. |
|
should the triview stuff be moved to templates/tri-view? Yes, I plan to move FireflyViewer and its related parts into templates as a separate refactoring task once templates is accepted. |
|
Conclusions:
I think the only thing you should change for this ticket is the template organization (tri-view in templates directory), other stuff we can iterate on). This is really good path forward. |
- move FireflyViewer related code into templates - create template mappings object in FFEntryPoint.js
To view light curver viewer use lc.html: ie. http://localhost:8080/firefly/lc.html
Upload a table to see the results.