Skip to content

DM-6289 Chart options - reset to default #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Conversation

tgoldina
Copy link
Contributor

  • Fixed truncated columns in table statistics processor (when col name is long)
  • Fixed NaN related issues in histogram processor
  • Reset in xyplot or histogram options resets options to the default.

How do we know the options are the default?

  • Chart is created from the menu drop down, options selected there are "the default"
  • Default chart, created with the default parameters
  • Chart is created via API, options passed via the API function are "the default"

@ejoliet
Copy link
Contributor

ejoliet commented Aug 26, 2016

I've tested the reset feature. It restore the default values that appeared the first time it displays the plot.

One caveat though: i did change values randomly and then reset, all is restored and plot is displayed ok. But labels are not replaced in the option panel when you reset, only after you apply and open the option panel back.

@tgoldina
Copy link
Contributor Author

When label and unit are set by the user (for example in chart drop down), they will be preserved on Reset.

When label and unit are not specified (empty), they are not part of the default parameters. When the chart is created, and no label or unit are present, the values from the table header will be used. If showing them in options creates confusion, we could probably remove them from table options.

Making unknown label and unit part of the default parameters is problematic, because the table is not always loaded at the time the plot is requested. (Like in API case.)

By the way, label and unit are automatically cleared, whenever the columns are changing.

@tgoldina tgoldina merged commit 8035128 into dev Aug 26, 2016
@tgoldina tgoldina deleted the dm-6289_chartreset branch August 26, 2016 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants