Skip to content

DM-7277: complete commit and fix #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2016
Merged

Conversation

ejoliet
Copy link
Contributor

@ejoliet ejoliet commented Aug 26, 2016

Please, review and let me know.

I've hidden the description column in xy-plot selecting column dialog (same behavior as in table component) when no description available.
This is the case in Gator/Atlas, which both use upload table mechanism in the API. In OPS, before migration, no description is shown in the table/xy-plot component.

To test, upload any ipac table catalog, this is not getting any description from the ipac table header, so nothing should be shown.

@wmiipac
Copy link
Contributor

wmiipac commented Aug 30, 2016

works as expected. good job. review completed.

@ejoliet ejoliet merged commit 7ddcfb9 into dev Aug 30, 2016
@ejoliet ejoliet deleted the DM-7277-hide-empty-description-col branch August 30, 2016 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants