Skip to content

DM-7239: Table reset does not reset to original settings. #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2016

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Aug 25, 2016

  • reset options based on original settings.
  • do not reload document unless it is needed.
  • do not redraw coverage with table is sorted

Reset should work like it did before.
Show units, show filters, column selections, and filters will be reset to what it was originally when table was loaded. On table sort, coverage image will not reset. However, it will be reset on filters changed. This is how it is in production as well.

 - reset options based on original settings.
 - do not reload document unless it is needed.
 - do not redraw coverage with table is sorted
@ejoliet
Copy link
Contributor

ejoliet commented Aug 25, 2016

Thanks!. Works as before migration. Review done.

@loitly loitly merged commit c8fc6b9 into dev Aug 25, 2016
@loitly loitly deleted the DM-7239_table_reset branch August 25, 2016 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants