Skip to content

DM-7275: fixed expanded modes display issues #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 23, 2016
Merged

DM-7275: fixed expanded modes display issues #150

merged 3 commits into from
Aug 23, 2016

Conversation

robyww
Copy link
Contributor

@robyww robyww commented Aug 20, 2016

  • always does single mode when the is only one plot
  • better use of expanded mode toolbar space using flex layout
  • fixed: color change failing when mask is plotted

@robyww
DM-7275: fixed expanded modes display issues
d61225c 
  - does single mode when the is only one plot
  - better use of space using flex layout
  - fixed - color change failing when mask is plotted
@ejoliet
Copy link
Contributor

ejoliet commented Aug 22, 2016

Thanks for looking at it!
I've checked that calling external viewer gives correctly single view mode on one image and tiled view on next images.
But when trying the expand mode on the 2x2 grid from here:
http://localhost:8080/firefly/demo/ffapi-highlevel-test.html

I can only see one image (single view?) and options to switch to tiled view or available list are no longer displayed. Could you check?

@robyww
Copy link
Contributor Author

robyww commented Aug 22, 2016

You are right. The ffapi-highlevel-test.html has all the images in different groups. The options button should have been there to choose the images. However, there is something still not right in how we are doing grouping, I am going to look at it a little more.

@robyww
Copy link
Contributor Author

robyww commented Aug 23, 2016

@ejoliet OK, i think i have fixed the bugs. You are welcome to look at it again or I can go ahead and merge.

@ejoliet
Copy link
Contributor

ejoliet commented Aug 23, 2016

Looks good. Review completed.

@robyww robyww merged commit e4c3322 into dev Aug 23, 2016
@robyww robyww deleted the dm-7275-expand-mode-look branch August 23, 2016 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robyww @ejoliet