Client-side filtering and table related cleanup #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- client-side filtering - added more jsdoc for table related code - fix filter input field auto-correct issue.
| * @prop {Object.<string, *>} options table options, ie. selectable, expandable | ||
| */ | ||
|
|
||
|
|
There was a problem hiding this comment.
Although the documentation above is dense and good, i don't think it will be written out in JSDocs html. What do you think?
There was a problem hiding this comment.
JSDoc should be able to generate docs with @typedef and @callback tags. They are standard tags.
|
All ok. Removed deprecated component, client filtering added, basic table options nicely used in the FITS headers dialog. Love the jsdocs added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-7136
Added table options to basic table as a property. Currently, options is available to fits headers as well as XYplot columns selections dialog.