DM-6950: improve overlay labels #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -127,7 +127,8 @@ function drawDirectionArrow(ctx,drawTextAry,startPt,endPt,drawParams,renderOptio | |||
|
|
|||
| //FIXME:color text black on white background - yellow on white background is not readable | |||
| //TODO: better solution would be to adapt text color with background | |||
| DrawUtil.drawText(drawTextAry, text, ret.textX, ret.textY,'black', renderOptions); | |||
| // DM-6950 | |||
| DrawUtil.drawText(drawTextAry, text, ret.textX, ret.textY, color, renderOptions); | |||
There was a problem hiding this comment.
you should take out the todo comments here since it is done.
|
This all looks good. I think it is better than it was. Looks cleaner. My only issue is just keeping the support at the low level so that if we case a case we want it. Review Complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed white background on the text labels and and made color the same as the overlay itself.
Please check that it is the case for the overlays in general (grid, markers, distance tool, compass).
Thanks!