DM-5793: Mask overlay support #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: - zoom works, rotate works. - files can't be rotate before reading in mask (no check for this yet) - drawing layer controls work - flip might work. I think it works on the client. Currently there is a bug fliping certain types of data on the server side. - crop does not work. I think the client is fine but there is a server bug as well - python support for mask: update add_mask and remove_mask for mask layer (this work was done by Cindy) - bugs fixes with loading image and mask in same python cell
| @@ -322,7 +322,8 @@ function processPlotReplace(dispatcher, result, pv, makeSuccessAction, makeFailA | |||
| var overlayPlotViews = []; | |||
| resultAry.forEach((r, i) => { | |||
| if (i === 0) return; | |||
| var plot = WebPlot.makeWebPlotData(pv.plotId, r.data[WebPlotResult.PLOT_CREATE], true); | |||
| const {imageOverlayId}= pv.overlayPlotViews[i-1]; | |||
| var plot = WebPlot.makeWebPlotData(imageOverlayId, r.data[WebPlotResult.PLOT_CREATE][0], {}, true); | |||
| overlayPlotViews[i - 1] = {plot}; | |||
| }); | |||
There was a problem hiding this comment.
just would like to confirm that that resultant length of overPlotViews is one less that of resultAry.
There was a problem hiding this comment.
Yes, the main image is 0 and the others are overlays
|
Review completed. What a big effort work!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: