DM-6473: Fixes mostly related to image view of the meta data via table #136
+194
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robyww
commented
Aug 4, 2016
robyww
commented
- images cannot be remove, but in expanded mode, it can.
- plot group fails are not failing correctly, no message shown
- When a non-meta table is selected, images are shown, but not the toolbar.
- After table is removed, images are still there and other problem with removing tables.
- Firefly viewer uses 'triViewImages’ viewer_id while api has no viewer_id. as a result, images loaded by api will be lost once table or other searched data are returned. (I think this is fixed, but I may not understand it)
- Catalog or Grid overlay are drawn outside of the images.
…meta data via table - images cannot be remove, but in expanded mode, it can. - plot group fails are not failing correctly, no message shown - When a non-meta table is selected, images are shown, but not the toolbar. - After table is removed, images are still there. - Firefly viewer uses 'triViewImages’ viewer_id while api has no viewer_id. as a result, images loaded by api will be lost once table or other searched data are returned. (I think this is fixed, but I may not understand it) - Catalog or Grid overlay are drawn outside of the images.
|
Review completed without any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.