DM-7029: fixed some api bugs #126
Conversation
- Image is coming with one draw layer. (I can delete this draw layer and nothing changes on the image) - When draw layer is deleted, and no more layers are present, the layers dialog should be closed. (It stays with nothing to display, you have to click x to close it.) - After selecting an area in one viewer, I select an area in another viewer, then move the mouse to the first one: 147 ImageViewerLayout.jsx:314 Uncaught TypeError: Cannot read property 'x' of null at ImageViewerLayout.jsx:314 Nothing works after that. I have to reload. - Selection appears with an offset, if the page, which contains the viewer is scrolled. (Load the attached script, press 'Start selection tracking' click to select a point, then scroll page a bit down, then click to select another point - it shows down from where it should be.) - I have 2 image viewers in separate divs. Selected line in one, then selected line in the other. The line from the first one disappeared, but its label is still there. (See attached image.) - Selection is working differently from distance. To select in another plot, I need to press selection again. I don't need to press ruler again to select new distance in another plot. - The payload.attValue of CHANGE_PLOT_ATTRIBUTE action is using WorldPt for area and point selections (when payload.attKey is 'SELECTION' or 'ACTIVE_POINT'), but ImagePt for line selection (when payload.attKey is 'ACTIVE_DISTANCE') How can I make them all use image coordinates? Now exporting the coordinage system conversion code. var imagePt= firefly.util.image.CCUtil.getImageCoords(plot,pt);
| @@ -31,6 +31,8 @@ export {RangeValues} from '../visualize/RangeValues.js'; | |||
| export {WPConst, WebPlotRequest, findInvalidWPRKeys, confirmPlotRequest} from '../visualize/WebPlotRequest.js'; | |||
| export {RequestType} from '../visualize/RequestType'; | |||
| export {ExpandType, dispatchApiToolsView} from '../visualize/ImagePlotCntlr.js'; | |||
| export {CsysConverter} from '../visualize/CsysConverter.js'; | |||
| export {CCUtil} from '../visualize/CsysConverter.js'; | |||
There was a problem hiding this comment.
To use CCUtil, we need to add the following exports:
export {primePlot} from '../visualize/PlotViewUtil.js';
export {visRoot} from '../visualize/ImagePlotCntlr.js';
There was a problem hiding this comment.
ok, I will do that too.
|
Thank you for quick turnaround. Most of the issues are fixed. Here is what I have noticed:
This seems to cause strange behavior, when selections do not work as expected. For example: select ruler, select some lines alternating first and second plot. Unselect ruler, select area icon. Selecting in the first plot will still show distance. I had to delete distance tool drawing layer or click on the border for things to start showing area selection. In general, there is some confusion with active plot, when I have two viewers. Should a plot become active as soon as mouse enters is? Otherwise in readout, compass thumbnail will still show active plot, while readout thumbnail could use another plot.
|
|
With selection, there is no delete. The drawing layers make that stuff optional. I can turn it on. |
|
#1 is a little beyond the scope of this ticket. I will make new ticket from it. DM-7068 |
|
Thank you. Then it's ready to merge. 2016-07-29 15:13 GMT-07:00 Trey Roby [email protected]:
|
display, you have to click x to close it.)
ImageViewerLayout.jsx:314 Uncaught TypeError: Cannot read property 'x' of null at ImageViewerLayout.jsx:314 Nothing works after
that. I have to reload.
'Start selection tracking' click to select a point, then scroll page a bit down, then click to select another point - it shows
down from where it should be.)
disappeared, but its label is still there. (See attached image.)
all use image coordinates? Now exporting the coordinage system conversion code.
var imagePt= firefly.util.image.CCUtil.getImageCoords(plot,pt);