Skip to content

DM-6908 Add filter editor to the chart toolbar #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2016
Merged

Conversation

tgoldina
Copy link
Contributor

  • Added filter editor to the charts toolbar
  • When filtering returns empty data set, server side will return header. Before, it was returning \Loading-Status = COMPLETED, and TablesCntlr:265 would never activate a new table callback.
  • Charts are cleared when table data are being fetched.
  • Label and unit in XYPlotOptions will now get cleared whenever x or y changes
  • removed tbl_id from CatalogWatcher and CoverageWatcher's server requests to prevent interference with the table
  • changed the order of lat,lon->lon,lat in CoverageWatcher's server request (just for consistency: it was dec, ra before)

@loitly
Copy link
Contributor

loitly commented Jul 21, 2016

clear filter button disappears after a region is selected.

  • apply a filter, clear filter button appears on top-left.
  • select a region in xyplot, clear button disappears.

@loitly
Copy link
Contributor

loitly commented Jul 21, 2016

clear filter text did not clear filter.

  • apply a filter. ie. ra > 0
  • select the text 'ra >0' then press 'delete'. tab or enter to apply the change. nothing happen.

@loitly
Copy link
Contributor

loitly commented Jul 21, 2016

table in filter editor is not sortable.

  • click on 'Column' column, nothing happen.

@loitly
Copy link
Contributor

loitly commented Jul 21, 2016

Done with review. Code is good. There are several things I pointed out above that may need fixing.

@loitly
Copy link
Contributor

loitly commented Jul 22, 2016

It looks good. Good to merge.

@tgoldina tgoldina merged commit 6a400e7 into dev Jul 22, 2016
@tgoldina tgoldina deleted the dm-6908_filteredit branch July 28, 2016 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants