Skip to content

DM-6952: Table problems #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2016
Merged

DM-6952: Table problems #121

merged 2 commits into from
Jul 27, 2016

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Jul 21, 2016

https://jira.lsstcorp.org/browse/DM-6952

Table component has couple of problems:

  • Scrambled table values after column selection and saving the table, then reset mess up the table. Saving the table and reset makes the table comes back.
  • table display no longer redefines column names in the table based on the column label, e.g. "Field Size" instead of "s_fov".
  • Downloaded file is not a valid IPAC table.
  • Filtering table does not change image overlay or plot until table is saved. At that point, the filtering works, but the plot symbol changes (happens when result is decimated, datapoints > 5000?)
  • In Edit Table Options, it's unclear what the reset button resets to.

Table component has couple of problems:
  - Scrambled table values after column selection and saving the table, then reset mess up the table. Saving the table and reset makes the table comes back.
  - table display no longer redefines column names in the table based on the column label, e.g. "Field Size" instead of "s_fov".
  - Downloaded file is not a valid IPAC table.
  - Filtering table does not change image overlay or plot until table is saved. At that point, the filtering works, but the plot symbol changes (happens when result is decimated, datapoints > 5000?)
  - In Edit Table Options, it's unclear what the reset button resets to.
@loitly
Copy link
Contributor Author

loitly commented Jul 21, 2016

In regard to the 5th bullet, reset button will:

  • unchecked show units and filters
  • clear all filters
  • set page size to 100
  • reset column selection to when table was first loaded.

@wmiipac
Copy link
Contributor

wmiipac commented Jul 21, 2016

Can't really test the fix with Atlas,shall I point firefly to you instead of irsawebdev1?

It's hard to say because 9071 was once used for testing. But since 9071 is your personal instance of irsa, I would expect you to point it to your local firefly built using this branch to test this pull request.

@ejoliet
Copy link
Contributor

ejoliet commented Jul 25, 2016

I've checked that the issues are fixed apart from the second bullet that ill be tested separately. Will be confirmed.
Regarding the ipac table format, table header is not kept after sorting/filtering.

@loitly loitly merged commit 7641864 into dev Jul 27, 2016
@loitly loitly deleted the DM-6952_table_problems branch July 27, 2016 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants