DM-6288 Chart Options Display #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ticket is about making chart options (and chart) display more consistent with that of the table. Chart Options will be displayed over the right side of the table.
|
I didn't see any problem whatsoever. Looks good. |
| zIndex: 100, | ||
| flex: '0 0 auto', | ||
| overflow:'auto', | ||
| boxShadow: '-2px 0 2px 0 rgba(0,0,0,0.50)' |
There was a problem hiding this comment.
i see lots of inline styling in this file. having them in a css file may look cleaner.
|
Only in Safari when scrollbar is visible, it cuts into the Reset button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ticket is about making chart options (and chart) display more consistent with that of the table. Chart Options will be displayed over the right side of the table. Overall look of the chart is more similar to the table.