DM-6022 Lazy load related chart data on table data update #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tgoldina
commented
Jul 6, 2016
tgoldina
commented
- Introduced CHART_MOUNTED/CHART_UNMOUNTED actions, deleted SETUP_TBL_TRACKING.
- Reworked the logic for chart related controllers. Chart data are updated only if a chart is mounted, no updates on unmounted charts.
- Now checking if connected table or server parameters have changed before placing server request for data
- Fixed setState calls on unmounted component in ChartContainer.
- Fixed delete button being shown in expanded mode.
| this.setState({chartType: getChartType(nextProps)}); | ||
| const {tblId, chartId, chartType} = nextProps; | ||
| if (!tblId || !chartId) { return; } | ||
| if (chartId != this.props.chartId || chartType != this.props.chartType || !this.props.tblId) { |
There was a problem hiding this comment.
just picky, !== instead of '!='
|
review is done. looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.