DM-5387: Filter Editor #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- auto-correction on the single filter fields - free-hand filters field validation and auto-correction - reset, clear filters as well. - 'Column' is sticky... scrolling left/right will not affect it.
|
In general everything works as expected but:
Like the filter table added to the table settings: is a great idea and work just fine! |
|
Problem found and duplicated: After sorting or filtering, text view no longer works and freeze the rest of the UI, only reloading the page give you back the UI in a stable state. uncaught TypeError: Cannot read property 'componentWillReceiveProps' of null(…) |
| var tableModel = cloneDeep(origTableModel); | ||
| set(tableModel, 'request.sortInfo', sortInfoStr); | ||
| const colIdx = columns.findIndex( (col) => {return col.name === colName;} ); | ||
| const col = columns[colIdx]; |
There was a problem hiding this comment.
what if 'colIdx' is -1, or it is not possible to happen?
|
review is done. Looks very good to me. |
- fix '>=' parsing errors. - Text View not working after sorting - added tooltips to table toolbar buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.lsstcorp.org/browse/DM-5387
to test: search catalog, open table options.