firefly api related issues due to irsa integration. #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
loitly
commented
Jun 20, 2016
loitly
commented
- default table cell to render html content as html.
- fix firefly_loader.js to take into consideration the location of from where it is loaded.
- paging bar show non-ascii characters in irsa's html
- fix firefly_loader.js to take into consideration the location of from where it is loaded. - paging bar show non-ascii characters in irsa's html
| @@ -168,10 +169,10 @@ export class TextCell extends React.Component { | |||
| // } | |||
| // | |||
| render() { | |||
| var val = getValue(this.props); | |||
| val = (val.search(html_regex) >= 0) ? <div dangerouslySetInnerHTML={{__html: val}} /> : val; | |||
There was a problem hiding this comment.
haha, react actually call this prop "dangerous"
- added rowHeight property to control the height of the table's row. - default to unselectable table when type is not specify. - added help_id property to table. set to 'tables' for old api - set expandable to false for old api call
|
made another commit based on updated ticket and pushed. ready for review, again. |
- middle align table cell content - fix image not loading in api mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.