Skip to content

Dm 4484 marker tool - create drawing layer for marker tool #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 17, 2016

Conversation

cwang2016
Copy link
Contributor

The implementation includes:

  • DrawObj for marker
  • Marker dropdown list under the marker icon to show the marker and footprint items (will be added later).
  • Marker drawing layer rendering and operation including action creator and action dispatch functions.
  • Marker UI component shown in Drawing Layers popup.
    The implementation set up some work which can be similarly expanded to footprints in the future.

Maker drawing layer operation:

  • select 'Add Marker' from dropdown list to add a new drawing layer
  • click anywhere to locate the newly added marker
  • click and drag the mouse to relocate or resize the marker:
    for relocation: click and drag inside the circle, then drag the mouse.
    for resize: click inside the circle, then click and drag the handler to resize
  • label and its location are set from Marker tool UI

@@ -50,6 +54,12 @@ const REGION_DELETE_LAYER = `${DRAWLAYER_PREFIX}.RegionPlot.deleteLayer`;
const REGION_ADD_ENTRY = `${DRAWLAYER_PREFIX}.RegionPlot.addRegion`;
const REGION_REMOVE_ENTRY = `${DRAWLAYER_PREFIX}.RegionPlot.removeRegion`;

// makler and footprint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picky: marker not makler

@robyww
Copy link
Contributor

robyww commented Jun 16, 2016

UI Comments:

  • Mostly it looks the like the old one and works better.
  • On the Layer control: show: <title>, It the title should change as you enter text for the label. For example, Marker-1 would be how it started but when the user enters 'my favorite' it should change to that.
  • The mouse should change to a pointer when you are on a marker. If you want to be really fancy it could change to a resize cursor on each resize box.
  • The size is not in world coordinates, the position but the size is not. When I zoom the image, the circle size does not change with the zoom level.

Cindy Wang and others added 2 commits June 16, 2016 13:43
…n the mouse action is ready for relocate and resize the marker.
…ous location is selected around the marker. change the size of the marker while zooming the image.
@cwang2016
Copy link
Contributor Author

more improvement,

  • on the layer control, show: <title> and the title change as you enter the text for the label.
  • the mouse changes to a pointer once the cursor moves onto the marker, and the mouse becomes a resize sign when the cursor moves on the handler of the marker.
  • When the cursor becomes a pointer, the marker can be relocated by dragging the mouse, and when the cursor becomes a resize one, the marker can be resized by dragging the mouse.
  • the marker size changes as the image is zoomed.

@cwang2016 cwang2016 merged commit 28efd18 into dev Jun 17, 2016
@cwang2016 cwang2016 deleted the DM-4484-MarkerTool branch June 17, 2016 06:40
@ejoliet
Copy link
Contributor

ejoliet commented Jun 17, 2016

Nice improvement!

On 6/16/16 11:39 PM, Cindy Wang wrote:

more improvement,

  • on the layer control, show: and the title change as you enter the
    text for the label.
  • the mouse changes to a pointer once
    the cursor moves onto the marker, and the mouse becomes a resize
    sign when the cursor moves on the handler of the marker.
  • When the cursor becomes a pointer, the marker can be relocated by dragging the mouse, and when the cursor becomes a resize one, the marker can be resized by dragging the mouse.
  • the marker size changes as the image is zoomed.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#104 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAvATK40ImgeVNvB3DPa9o5kujKfBsL8ks5qMkEogaJpZM4I3DDD.

Emmanuel Joliet
NASA/IPAC Infrared Science Archive
MS 100-22, Caltech, Pasadena, CA 91125
Office: 170
Email: [email protected]
Phone: (626) 395-1489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants