Skip to content

Typescript types incompatible with recent versions of @types/seedrandom #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richvdh opened this issue May 17, 2024 · 1 comment
Closed

Comments

@richvdh
Copy link

richvdh commented May 17, 2024

Since DefinitelyTyped/DefinitelyTyped#63766, seedrandom.State is no longer a defined type; however prng.state() is still defined to return a State. Obviously, this causes a typescript error.

github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue May 20, 2024
* persist previously-reported event IDs as a bloom filter

* Pin to older `@types/seedrandom`

... to work around Callidon/bloom-filters#72

* Inline `DecryptionFailureTracker.addDecryptionFailure`

* Remove redundant TRACK_INTERVAL

There really doesn't seem to be much point to this batching up of decryption
failure reports. We still call the analytics callback the same number of times.

* Rename `trackedEvents` to `reportedEvents`

* Fix incorrect documentation on `visibleEvents`

This *does* overlap with `failures`.

* Combine `addFailure` and `reportFailure`

* Calculate client properties before starting reporting

* Clear localstorage after each test

... otherwise they interfere

* Remove redundant comment

* Ensure that reports are cleared on a logout/login cycle

* make private const private and const

---------

Co-authored-by: Richard van der Hoff <[email protected]>
@folkvir
Copy link
Collaborator

folkvir commented Jun 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants