Reworking of the ObserverTimeEvolution #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> detList still available as option -> custom function option added
…d getTime function
JanNiklasB
commented
Dec 19, 2024
JanNiklasB
commented
Dec 19, 2024
JanNiklasB
commented
Dec 19, 2024
JanNiklasB
commented
Dec 19, 2024
added 4 commits
March 4, 2025 01:08
- fixed wrong scaling in constructor - fixed unexpected behavior in getTimes - added more detailed documentation - replaced customGetTime with virtual on getTime since it is only used inside c++
- modified Test for checkDetection - added Test for behavior with arrays instead of getTime function - added clear and empty function
- further fixed a floating point issue in testBreakCondition
|
After discussing pull request with @JulienDoerner, I added setter and getter functions as well as some older functions that I previously removed to preserve compatibility.
For a more detailed description of the single changes, see the comments. |
JanNiklasB
commented
Mar 6, 2025
JanNiklasB
commented
Mar 6, 2025
JanNiklasB
commented
Mar 6, 2025
JanNiklasB
commented
Mar 6, 2025
JanNiklasB
commented
Mar 6, 2025
JulienDoerner
requested changes
Mar 6, 2025
There was a problem hiding this comment.
Hey @JanNiklasB,
the overall changes look good for me and it improves the usability for non-uniform observations.
I left some comments about code style (see below).
And can you please add your changes to the CHANGELOG.md.
added 3 commits
March 6, 2025 18:48
- Replaced EXPECT_TRUE with EXPECT_NEAR in TimeEvolutionArray
- all changes to variables now over setter functions - valid range check for min if isLogarithmicScaling = true now in setMinimum
JulienDoerner
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear All,
in this pull request, I want to introduce a reworked
ObserverTimeEvolution.I replaced the
addTimeRangefunction which filled thedetListarray with a functionthat takes the required index as an argument and returns the time that should be observed.
For that, I also changed other parts of the
ObserverTimeEvolutionclass tocorrectly utilize that new
getTimefunction.I also kept the option of using a
detListby utilizing a new constructor.Furthermore, it is possible to use a user-defined
getTimefunction by utilizingthe
setUserDefinedGetTimefunction.Additionally, I fixed the issue mentioned in #510.
For that, it was necessary to change some tests, since those handled
the maximum observed time like
max = numb * distwhen it shouldbe handled like
max = min + numb * dist.