-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DLT Upstream for minor release #515
Merged
michael-methner
merged 26 commits into
COVESA:master
from
minminlittleshrimp:upstream_v2
Aug 10, 2023
Merged
DLT Upstream for minor release #515
michael-methner
merged 26 commits into
COVESA:master
from
minminlittleshrimp:upstream_v2
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding policy for the path of internal dlt log. Signed-off-by: Dinh Cong Toan <[email protected]>
Same contexts were unregistered twice, hence removing them. Signed-off-by: Saya Sugiura <[email protected]>
Signed-off-by: Saya Sugiura <[email protected]>
The incorrect check of local_filename. If that is an array of characters, we should check the first character against 0 Signed-off-by: Bui Nguyen Quoc Thanh <[email protected]>
In order to use correct path to dlt-daemon, environment variable DLT_UT_DAEMON_PATH is introduced in gateway gtest Signed-off-by: Saya Sugiura <[email protected]> Signed-off-by: mayaz <[email protected]>
Signed-off-by: Saya Sugiura <[email protected]>
Signed-off-by: Bui Nguyen Quoc Thanh <[email protected]>
Add jsoncpp lib to Android.bp Signed-off-by: LUU QUANG MINH <[email protected]>
Signed-off-by: LUU QUANG MINH <[email protected]>
+ Construct functions for json parsing and json tag matching + Create conf file + Add an example of json file Signed-off-by: LUU QUANG MINH <[email protected]>
When partial DLT messages are received by DLT Daemon from the application side, to prevent errors in the DLT Client when such messages are being parsed, identify & ignore them inside the receiver buffer. Signed-off-by: Suprathik Narasimhaiah <[email protected]>
+ Fix memory leak if tag duplicated in json file. + Remove minor duplicated warning message. Signed-off-by: LUU QUANG MINH <[email protected]>
Signed-off-by: LUU QUANG MINH <[email protected]>
Remove unrelated part in script for qnx system test Signed-off-by: LUU QUANG MINH <[email protected]>
Add some binaries for RFW testcases in Android Signed-off-by: Le Tin <[email protected]>
Socket is shutdown and closed before that, so thread will complete its task, here is the listening task Calling pthread_cancel does not need here Signed-off-by: Le Tin <[email protected]>
Before writing to the timer pipes, the fd must be checked to ensure that it is a valid fd Signed-off-by: Bui Nguyen Quoc Thanh <[email protected]>
Improve mechanism to help overflow message sent only one time Signed-off-by: Bui Nguyen Quoc Thanh <[email protected]>
Signed-off-by: LUU QUANG MINH <[email protected]>
Increase buffer sizes to get longer file paths, hence avoiding test fails. Signed-off-by: LUU QUANG MINH <[email protected]>
+ Add header file + Add gtest file source + Small modification for binary source code + Add test for dlt-logd-converter in CMakeLists Signed-off-by: LUU QUANG MINH <[email protected]>
Signed-off-by: LUU QUANG MINH <[email protected]>
+ Remove wrong implemented abmormal test case + Setup condition in source code to avoid throwing SIGSEGV + Modify test suite for modified source parts Signed-off-by: LUU QUANG MINH <[email protected]>
…nverter + Modify source code to bypass the abnormal case when reading conf file + Trigger and modify the corresponding abnormal test case Signed-off-by: LUU QUANG MINH <[email protected]>
Signed-off-by: LUU QUANG MINH <[email protected]>
Signed-off-by: Mohammad Ayaz <[email protected]>
michael-methner
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @minminlittleshrimp ,
thanks for the PR. For next time: please keep your PR small and atomic, that keeps review process easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream for next minor release of dlt