[WNMGDS-3189] Fix ds-autocomplete storybook controls
#3571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamara-corbalt
added
Type: Fixed
jack-ryan-nava-pbc
approved these changes
May 8, 2025
kim-cmsds
approved these changes
May 9, 2025
tamara-corbalt
deleted the
tamara/WNMGDS-3189/fix-ds-autocomplete-storybook-controls
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed
valueattribute from the publicds-autocompleteinterface. There doesn't seem to be a clear use case for allowing external control of the input value. The previous storybook implementation appears to have masked the fact that forcibly passing a value breaks the expected behavior of the component.Added missing formAttrs to
ds-autocompletestorybook controls.Jira ticket
How to test
npm test:unit:wcChecklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.