-
Notifications
You must be signed in to change notification settings - Fork 92
[WNMGDS-3336] Update text-field
guidance
#3542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WNMGDS-3336] Update text-field
guidance
#3542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks good, but I think the code section move is an unintended change on our part? Looking at the content doc I think we might have implied the move but that'll make it inconsistent with the rest of the docsite. @andream-cmsds do you remember if we intended to reorder the sections?
Hi @sophia-cmsds @andream-cmsds — I tried to base the ordering on this Confluence doc, which outlines the following sequence:
Since |
Ahh sorry I definitely didn't reference that template. Looks good to me then; tagging in @andream-cmsds for any last thoughts. |
@tamara-corbalt let's put |
Awesome! Thanks, I'll push up the changes |
…WNMGDS-3336/implement-text-field-guidance
Summary
text-field
components.How to test
Question for designers: Should the
Related patterns
andLearn more
sections appear before or after theCode
section?Checklist
[WNMGDS-####] Title
or [NO-TICKET] if this is unticketed work.Type
(only one) label for this PR, if it is a breaking change, label should only beType: Breaking
Impacts
, multiple can be selected.