Skip to content

[WNMGDS-3336] Update text-field guidance #3542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025

Conversation

tamara-corbalt
Copy link
Collaborator

Summary

  • Makes updates to guidance on text-field components.

How to test

  1. Compare the preview to the PDF spec and confirm they match.

Question for designers: Should the Related patterns and Learn more sections appear before or after the Code section?

Checklist

  • Prefixed the PR title with the Jira ticket number as [WNMGDS-####] Title or [NO-TICKET] if this is unticketed work.
  • Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • Selected appropriate Impacts, multiple can be selected.
  • Selected appropriate release milestone

@tamara-corbalt tamara-corbalt added Impacts: Documentation Indicates that this item relates to documentation Type: Added Indicates a new feature. labels Apr 16, 2025
@tamara-corbalt tamara-corbalt added this to the 12.3.0 milestone Apr 16, 2025
@tamara-corbalt tamara-corbalt marked this pull request as ready for review April 16, 2025 20:21
Copy link
Contributor

@phiden phiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good, but I think the code section move is an unintended change on our part? Looking at the content doc I think we might have implied the move but that'll make it inconsistent with the rest of the docsite. @andream-cmsds do you remember if we intended to reorder the sections?

@tamara-corbalt
Copy link
Collaborator Author

Content looks good, but I think the code section move is an unintended change on our part? Looking at the content doc I think we might have implied the move but that'll make it inconsistent with the rest of the docsite. @andream-cmsds do you remember if we intended to reorder the sections?

Hi @sophia-cmsds @andream-cmsds — I tried to base the ordering on this Confluence doc, which outlines the following sequence:

// ... Other sections...

- Accessibility
...

- Code
...

- Component maturity
...

Since Learn more and Related patterns aren’t mentioned in the doc, I placed them between Accessibility and Code. That said, I’m not confident this is the right spot.

@phiden
Copy link
Contributor

phiden commented Apr 21, 2025

Ahh sorry I definitely didn't reference that template. Looks good to me then; tagging in @andream-cmsds for any last thoughts.

@andream-cmsds
Copy link
Collaborator

@tamara-corbalt let's put Learn more and Related patterns after the Code section. Thanks! Sorry for the confusion.

@tamara-corbalt
Copy link
Collaborator Author

@tamara-corbalt let's put Learn more and Related patterns after the Code section. Thanks! Sorry for the confusion.

Awesome! Thanks, I'll push up the changes

@tamara-corbalt tamara-corbalt merged commit 162a262 into main Apr 22, 2025
1 check passed
@tamara-corbalt tamara-corbalt deleted the tamara/WNMGDS-3336/implement-text-field-guidance branch April 22, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts: Documentation Indicates that this item relates to documentation Type: Added Indicates a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants