[WNMGDS-2625] Remove core-js polyfills for IE
#2866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwolfert
added
Impacts: Core
zarahzachz
approved these changes
Jan 3, 2024
Karak888
added
the
Status: In JIRA
pwolfert
changed the title
core-js polyfills for IEcore-js polyfills for IE
pwolfert
removed
the
Status: In JIRA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2845 by removing
core-jsimports from the design system, which we only needed for IE support. See the impact analysis here.How to test
I temporarily added bundle-analyzing capabilities to the build system and compared before and after. Either trust me or verify through some similar means. It's irradicated from our design system dependencies and bundles, even though it's still a dependency of Gatsby.
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.