pair/tuple defaults #1081
Merged
pair/tuple defaults #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er parsing in some cases
…o pair_defaults
…o pair_defaults
phlptp
commented
Nov 7, 2024
| @@ -307,6 +307,30 @@ template <typename S> class is_tuple_like { | |||
| static constexpr bool value = decltype(test<S>(0))::value; | |||
| }; | |||
|
|
|||
| /// This will only trigger for actual void type | |||
There was a problem hiding this comment.
code moved to get thing in the right order
phlptp
commented
Nov 7, 2024
| result.back() == ']') { // this is now a vector string likely from the default or user entry | ||
| result.pop_back(); | ||
|
|
||
| for(auto &var : CLI::detail::split(result.substr(1), ',')) { | ||
| for(auto &var : CLI::detail::split_up(result.substr(1), ',')) { |
There was a problem hiding this comment.
wasn't handling sub vectors properly
|
@henryiii FYI, no api changes here, Mainly getting the default_val on parity with the types the options support themselves. Also cleaned up a few methods. Was a bug that came up a while ago and hadn't got around to fixing until now. I will merge in a few days |
Merged
phlptp
added a commit
that referenced
this pull request
Nov 18, 2024
Fixes issue #1086. In the default_val enums of uint8_t would read in as a string as they could be converted to a string. This worked ok for normal values, but when a check was added for specific strings, it caused an error when the default_val was added. This PR fixes the issue. The builder for coverage was updated to CMake 3.31 (by github), this triggered an error in the coverage tool script. This led to updating that script, which led to uncovering some missing coverage, which led to additional tests, which led to some issues around single element tuples support from #1081, which led to a few other issues that came up in the to_string operation and templates. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add capability to accept pair/tuple default values and a little cleaner parsing in some cases
Fixes #711