Skip to content

Refactor interpolation and metrics field #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

yiluchen1066
Copy link
Contributor

@yiluchen1066 yiluchen1066 commented May 21, 2025

  • add a new register _compute_nudgecoeffs in interpolation factory
  • add a new register for a field computation in metrics factory
    • add the computation function
    • add the new attributes
    • add the new tests

-refactor the metrics factory:

  • replace the z_ifc_indices with the topography
  • et al.

yiluchen1066 and others added 29 commits May 21, 2025 17:25
…dvantage of resgistering in the metrics field
@yiluchen1066
Copy link
Contributor Author

cscs-ci run default

@yiluchen1066
Copy link
Contributor Author

cscs-ci run default

@yiluchen1066 yiluchen1066 requested a review from halungge June 23, 2025 19:11
@yiluchen1066
Copy link
Contributor Author

cscs-ci run default

@yiluchen1066
Copy link
Contributor Author

cscs-ci run default

Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

  • cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

@yiluchen1066
Copy link
Contributor Author

cscs-ci run default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants