Added model/atmosphere/subgrid_scale_physics/muphys Microphysics #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly test_rain_to_graupel_1 is failing
…remely small differences around and below qmin
…pitations (RSIG). There are errors in the realm of 10^-13, probably due to the deactivation of kmin.
…s in the order 10^{-13} and smaller, which are not too troubling, but probably can also be avoided.
…s roundoff differences when .NOT. lrain
…able for gtfn backends
…and mini.nc test cases.
…d to dace_cpu for python_test.py
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
muphys is an alternative microphysics scheme which has been implemented with numerous "performance portable" paradigms (OpenACC, OpenMP, Kokkos, SYCL and now GT4Py) in order to compare performance and to help make decisions about implementation of new and reimplemented code in the ICON model.
The GT4Py implementation introduces about 100 new unit tests and one standalone application. The standalone yields only only round-off differences with the sequential base code. The unit tests are all passing with the default backend on a laptop, but one test fails with other backends on Santis, while another test, "Saturation Adjustment" takes near-infinite time to compile with
gtfn_cpu. It does however compile in about 20 minutes and pass withdace_cpu. Tests all fail with GPU backends currently.