Don't merge: hack skip values #728
Conversation
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
| offset_provider = method(*args) if args else method() | ||
| if gtx_common.is_neighbor_connectivity(offset_provider): | ||
| offset_provider_type = offset_provider.__gt_type__() | ||
| if True: #not offset_provider_type.has_skip_values: |
There was a problem hiding this comment.
I would expect that removing -1s for fields that don't have skip_values set would be enough, because all that have skip_values should be protected by a can_deref.
There was a problem hiding this comment.
According to Till the can_deref only protects the neighbor sums, if there is a direct access like CONN[0] this does not help.
There was a problem hiding this comment.
I meant, if the user claims has_skip_values, then the user has to use neighbor_sum.
Add a function that removes remaining skip values from the neighbor tables. This replaces [PR 728](#728) - Replacing the skip values is configurable by a flag in the `GridConfig`. - when `GridConfig.keep_skip_values = False` the skip values in the neighbortables of the `Connectivity` will be replaced by the max index in the neighborhood of an entity. This is done for all except for the pentagon points in a global grid. --------- Co-authored-by: Hannes Vogt <[email protected]>
|
merged in #761 |
Add a function that removes remaining skip values from the neighbor tables. This replaces [PR 728](#728) - Replacing the skip values is configurable by a flag in the `GridConfig`. - when `GridConfig.keep_skip_values = False` the skip values in the neighbortables of the `Connectivity` will be replaced by the max index in the neighborhood of an entity. This is done for all except for the pentagon points in a global grid. --------- Co-authored-by: Hannes Vogt <[email protected]>
No description provided.